Android H265 support

[Florian Grill]

Hi,

sorry for the maybe dumb question but I'm a little bit confused how the Android sdk works?

Here it is mentioned that H265 is supported as fars as I have understood 

https://github.com/ant-media/WebRTC-Android-SDK/tree/master/webrtc-android-framework

And I found following pull requests in regards this topic

https://github.com/ant-media/WebRTC-Android-SDK/commit/1c73f9fd8d44dc3e1ba1878689d39a2df61da079

But later on it seems this chanhe was reverted again with update "updated webrtc version to m85"

https://github.com/ant-media/WebRTC-Android-SDK/commit/cf912f990b1876ba48c19eab7edf4caaa23ee3bc

Now it doesn't add the 265 decoder to the supported codecs in the VideoDecoderFactory class anymore.

For my project I need to support h265 but not sure if it is now supported or not? If it is what kind of patches to you have actually now applied (native webrtc code and Android java code)? Thanks for you help.

[usama]

It supports H265 can you please check this blog out for detailed information https://antmedia.io/the-first-hevc-h265-support-in-webrtc/ 

Thanks 

Edited December 3, 2022 by usama

[Florian Grill]

On 12/3/2022 at 6:23 AM, usama said:

It supports H265 can you please check this blog out for detailed information https://antmedia.io/the-first-hevc-h265-support-in-webrtc/ 

Thanks 

I know this blog but why does the current master of the webrtc ant media Android sdk branch reverted the h265 changes? Default decoder factory is not returning h265?

What kind of patches was applied to the native webrtc lib to make h265 work? I'm interested in this changes as I have to compile the lib myself to get some additional information but I guess I loose then h265 support or is this not the case?

 

Edited December 4, 2022 by Florian Grill

[Florian Grill]

On 12/3/2022 at 6:23 AM, usama said:

It supports H265 can you please check this blog out for detailed information https://antmedia.io/the-first-hevc-h265-support-in-webrtc/ 

Thanks 

More specific in the article it is mentioned

 

"The recent changes are adding packetization and depacketization of HEVC frames in RTP protocol according to RFC 7789 and adapting these changes to the WebRTC stack. We’ve also adapted these changes to the Android WebRTC SDK because most android devices have H.265 decoder to play the H.265 encoded WebRTC Stream."

What are these changes and how can you see them?

[mustafaboleken]

Hi @Florian Grill

We don't revert H265 changes on Android. Can you please tell us your phone model so, we can check it?

We are planning to update the WebRTC version to m107 and it will be released soon. Maybe we should check it together after this update.

[Florian Grill]

On 12/9/2022 at 1:48 PM, mustafaboleken said:

Hi @Florian Grill

We don't revert H265 changes on Android. Can you please tell us your phone model so, we can check it?

We are planning to update the WebRTC version to m107 and it will be released soon. Maybe we should check it together after this update.

Hi thanks for your answer, what I meant is this (but maybe I'm just confused by looking at the code)

"

And I found following pull requests in regards this topic

https://github.com/ant-media/WebRTC-Android-SDK/commit/1c73f9fd8d44dc3e1ba1878689d39a2df61da079

But later on it seems this chanhe was reverted again with update "updated webrtc version to m85"

https://github.com/ant-media/WebRTC-Android-SDK/commit/cf912f990b1876ba48c19eab7edf4caaa23ee3bc

"

In the above pull request H265 was added in the DefaultVideoEncoderFactory java class but the other pull request ( updated webrtc version to m85) removed it. When I look now in the master branch

https://github.com/ant-media/WebRTC-Android-SDK/blob/master/webrtc-android-framework/src/main/java/org/webrtc/DefaultVideoEncoderFactory.java

No H265 codec is returned in the DefaultVideoEncoderFactory?

In regards to the updating to the m107 release that sounds great. In the description it is mentioned that some h265 patches were applied to the official stack to fully support h265 but I guess these patches are not publicly accessible, or are they?

[mustafaboleken]

2 hours ago, Florian Grill said:

Hi thanks for your answer, what I meant is this (but maybe I'm just confused by looking at the code)

"

And I found following pull requests in regards this topic

https://github.com/ant-media/WebRTC-Android-SDK/commit/1c73f9fd8d44dc3e1ba1878689d39a2df61da079

But later on it seems this chanhe was reverted again with update "updated webrtc version to m85"

https://github.com/ant-media/WebRTC-Android-SDK/commit/cf912f990b1876ba48c19eab7edf4caaa23ee3bc

"

In the above pull request H265 was added in the DefaultVideoEncoderFactory java class but the other pull request ( updated webrtc version to m85) removed it. When I look now in the master branch

https://github.com/ant-media/WebRTC-Android-SDK/blob/master/webrtc-android-framework/src/main/java/org/webrtc/DefaultVideoEncoderFactory.java

No H265 codec is returned in the DefaultVideoEncoderFactory?

In regards to the updating to the m107 release that sounds great. In the description it is mentioned that some h265 patches were applied to the official stack to fully support h265 but I guess these patches are not publicly accessible, or are they?

You are right, I will inform the person who updates to m107 about these patches. I didn't know about these patches before but definitely check it. Thank you very much.

[Florian Grill]

10 hours ago, mustafaboleken said:

You are right, I will inform the person who updates to m107 about these patches. I didn't know about these patches before but definitely check it. Thank you very much.

Okay great thanks.

The person who is working on the native webrtc m107 patch (to support H265) does he share these patches somewhere or are they private?